chore: optimize comments of the ParentSelector config #927
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaius <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #927 +/- ##
=======================================
Coverage 34.58% 34.58%
=======================================
Files 60 60
Lines 9308 9308
=======================================
Hits 3219 3219
Misses 6089 6089
|
yxxhero
approved these changes
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request includes several updates and improvements to the
dfdaemon.rsfile in thedragonfly-client-configmodule. The changes primarily focus on refining theParentSelectorconfiguration and updating associated documentation.Refinements to
ParentSelectorConfiguration:default_parent_selector_sync_intervalanddefault_parent_selector_capacityfunctions to set default values for the sync interval and capacity of the parent selector.default_parent_selector_sync_intervalanddefault_parent_selector_capacityto avoid duplication. [1] [2]Documentation Updates:
ParentSelectorand its fields, including the sync interval and capacity. [1] [2]Related Issue
dragonflyoss/dragonfly#3713
Motivation and Context
Screenshots (if appropriate)